[LLHD] Make process lowering best-effort and allow constants from outside the region #7617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
Sep 23, 2024
Comment on lines
44
to
50
| if (!isa<llhd::HaltOp>(op.getBody().back().getTerminator())) { | ||
| LLVM_DEBUG({ | ||
| llvm::dbgs() | ||
| << "entry block is required to be terminated by llhd.halt\n"; | ||
| }); | ||
| return failure(); | ||
| } |
There was a problem hiding this comment.
Is it legal to inline a process with a halt terminator into the parent module? Wouldn't the process only execute once, but the inlined version would be continuously executed?
There was a problem hiding this comment.
That's right, let me remove this case. Not sure why it was there to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.