[Python][OM] Handle BoolAttr's before IntegerAttr's. #7438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: Test needed minor touchups, but indeed fails before and passes after now. |
BoolAttr's are IntegerAttr's, check them first. IntegerAttr's that happen to have the characteristics of BoolAttr will accordingly become Python boolean values. Unclear where these come from but we do lower booleans to MLIR bool constants so make sure to handle that.
dtzSiFive
force-pushed
the
fix/py-boolattr
branch
from
2d9a025
to
05ec568
Compare
dtzSiFive
requested review from
mikeurbach and
seldridge
and removed request for
mikeurbach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test for bool constants that fails without this change.