Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python][OM] Handle BoolAttr's before IntegerAttr's. #7438

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

dtzSiFive
Copy link
Contributor

Add integration test for bool constants that fails without this change.

@dtzSiFive
Copy link
Contributor Author

dtzSiFive commented Aug 5, 2024

Haven't checked the integration test yet (before or after), marking draft until local build with python bindings enabled goes through (hopefully/probably our CI will come back first).

EDIT: Test needed minor touchups, but indeed fails before and passes after now.

BoolAttr's are IntegerAttr's, check them first.

IntegerAttr's that happen to have the characteristics of
BoolAttr will accordingly become Python boolean values.

Unclear where these come from but we do lower booleans
to MLIR bool constants so make sure to handle that.
@dtzSiFive dtzSiFive marked this pull request as ready for review August 5, 2024 16:41
@dtzSiFive dtzSiFive requested review from mikeurbach and seldridge and removed request for mikeurbach August 5, 2024 16:42
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtzSiFive dtzSiFive merged commit bec0dea into llvm:main Aug 5, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the fix/py-boolattr branch August 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants