[ImportVerilog] Add rvalue assignment pattern support #7428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailongSun2000
approved these changes
Aug 4, 2024
Comment on lines
+746
to
+748
| for (unsigned replIdx = 1; replIdx < replCount; ++replIdx) | ||
| for (unsigned elementIdx = 0; elementIdx < elementCount; ++elementIdx) | ||
| elements.push_back(elements[elementIdx]); |
There was a problem hiding this comment.
nit: With the existing tests, the elementCount is always 1. I noticed that slang supports arr = '{3{'{3{'0, '1}}}};. I'm not sure whether {'0, '1} is considered two element counts. Maybe we can add this as a case.
There was a problem hiding this comment.
Excellent point! I have adjusted the tests to cover the case you're describing 😃
Add support for assignment patterns like `'{42, 9001}` in rvalue
position. These are roughly SystemVerilog's equivalent of
`struct_create` and `array_create`. This commit also adds an
`array_create` op to support assignment patterns for arrays.
fabianschuiki
force-pushed
the
fschuiki/moore-assign-patterns
branch
from
5cb8005
to
b87da21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for assignment patterns like
'{42, 9001}in rvalue position. These are roughly SystemVerilog's equivalent ofstruct_createandarray_create. This commit also adds anarray_createop to support assignment patterns for arrays.