[LLHD] Add TemporalCodeMotionPass #7381
Merged
+586
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pass can be run after early code motion and brings the IR in an easier from for desequentialization. Canonicalization should be run directly afterwards to significantly simplify the control flow. Once we also have the desequentialization pass some mem2reg pass for inout values, we should be able to transform most of the LLHD processes produced by the MooreToCore pass to pure HW/Comb/Seq IR suitable for simulation using Arcilator.
fabianschuiki
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Really cool! 🥳
I'm wondering if instead of erroring out if the pass sees an input that has more than 2 TRs, the pass could just not perform the transformation and leave the process unmodified (or in a valid state). Simulations for example would still be able to run even if TCM did not run through, so it might be worthwhile not erroring out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass can be run after early code motion and brings the IR in an easier from for desequentialization. Canonicalization should be run directly afterwards to significantly simplify the control flow. Once we also have the desequentialization pass some mem2reg pass for inout values, we should be able to transform most of the LLHD processes produced by the MooreToCore pass to pure HW/Comb/Seq IR suitable for simulation using Arcilator.