Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MooreToCore] Lower var, read, and assign into LLHD. #7297

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[MooreToCore] Lower var, read, and assign into LLHD. #7297

merged 1 commit into from
Jul 15, 2024

Conversation

hailongSun2000
Copy link
Member

@hailongSun2000 hailongSun2000 commented Jul 10, 2024 •
edited
Loading

Lowering as the follow:
moore.variable ---> llhd.sig
moore.read ---> llhd.prb
moore.assign ---> llhd.drv
And I remove the trait(ParentOneOf<["llhd::EntityOp", "llhd::ProcOp"]>) of LLHD_SigOp.

fabianschuiki
fabianschuiki approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hailongSun2000 hailongSun2000 force-pushed the hailong/lower-some-ops-into-LLHD branch from de78980 to a443272 Compare July 15, 2024 03:38
@hailongSun2000 hailongSun2000 merged commit 4673afe into llvm:main Jul 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@maerhart maerhart Awaiting requested review from maerhart maerhart is a code owner

Assignees
No one assigned
Labels
Moore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hailongSun2000 @fabianschuiki