Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Add input and output names to DPI intrinsic #7265

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Jul 2, 2024

Fix #7226. This adds support for specifying input and output names. This uses ; separated string list following the same design as guard parameter of assert intrinsic.

Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!! 🚀

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uenoku uenoku merged commit 0bcfbdc into main Jul 3, 2024
4 checks passed
@uenoku uenoku deleted the dev/hidetou/dpi-name branch July 3, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIRRTL] Add optional arg name to DPI-C functions
4 participants