[ImportVerilog] Support Generate constructs #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelzzzzz
force-pushed
the
slang-generate
branch
from
0b09bde
to
b79e6e2
Compare
uenoku
reviewed
Jun 27, 2024
Comment on lines
+389
to
+392
| for (const auto *member : genArrNode.entries) { | ||
| if (failed(member->asSymbol().visit(MemberVisitor(context, loc)))) | ||
| return failure(); | ||
| } |
There was a problem hiding this comment.
Oh interesting. Does Slang resolve generate statements in their side?
There was a problem hiding this comment.
Yes! Slang will expand all structures as GenerateBlock, here is the JSON of two GenerateBlocks, we can figure out which will be generated by isUninstantiated:
{
"name": "",
"kind": "GenerateBlock",
"addr": 110809374896152,
"members": [
{
"name": "g3",
"kind": "Variable",
"addr": 110809374896280,
"type": "int",
"initializer": {
"kind": "IntegerLiteral",
"type": "int",
"value": "2",
"constant": "2"
},
"lifetime": "Static"
}
],
"constructIndex": 3,
"isUninstantiated": false
},
{
"name": "",
"kind": "GenerateBlock",
"addr": 110809374896624,
"members": [
{
"name": "g3",
"kind": "Variable",
"addr": 110809374896752,
"type": "int",
"initializer": {
"kind": "IntegerLiteral",
"type": "int",
"value": "3",
"constant": "3"
},
"lifetime": "Static"
}
],
"constructIndex": 3,
"isUninstantiated": true
}
angelzzzzz
force-pushed
the
slang-generate
branch
from
b79e6e2
to
72a6577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support loop generate constructs and conditional generate constructs.
Because
genvaronly exists in the declaration and the variable exists as a parameter in GenerateBlock, genvar can be skipped.