-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIRRTL] Allow layers under when and match. #7234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include tests of a layer block under a when under a layer block? Also, can you include a test of an assert under a when under a layer block?
Do these both work?
This is already included in the modified
Those appeared to work in local testing -- I'll add tests for these as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Behavior is same as-if the contained operations were not under a layer.
8a04319
to
b2f2d1a
Compare
Behavior is same as-if the contained operations were not under a layer.
Behavior is same as-if the contained operations were not under a layer.
Some layer-related passes such as LayerMerge (for completeness) and LowerLayers (for correctness) now explicitly require ExpandWhen's to execute first.
The FIRRTL specification does not yet permit this.