Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][FIRParser] Tokenize Commas #7206

Merged
merged 5 commits into from
Jul 18, 2024
Merged

[FIRRTL][FIRParser] Tokenize Commas #7206

merged 5 commits into from
Jul 18, 2024

Commits on Jun 26, 2024

  1. Fix up tests so they are strict about commas.

    @mmaloney-sf
    mmaloney-sf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ba0a315 View commit details
    Browse the repository at this point in the history

  2. Tokenize commas.

    @mmaloney-sf
    mmaloney-sf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    986d771 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Fold comma-delimiter logic into parseListUntil(). 

    Add a few more tests.
    @mmaloney-sf
    mmaloney-sf committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    529903b View commit details
    Browse the repository at this point in the history

  2. Always parse optional info for smem statement.

    @mmaloney-sf
    mmaloney-sf committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    065d289 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. nits.

    @mmaloney-sf
    mmaloney-sf committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    526257b View commit details
    Browse the repository at this point in the history