[Moore] Introduce a new operation - netOp for net declaration

[cepheus69]

According to the IEEE 1800-2017 std, we design netOp for net declaration. Various NetKind are supported to generate in the net declaration:

• Supply0 Supply1
• Wire Uwire
• WAnd WOr
• Tri0 Tri1
• Tri TriAnd TriOr TriReg
  The interconnect net declaration and user-defined net types are not supported yet.

[cepheus69]

The netOp is mainly used for declaring NetKind elements in the module. The NetKind has:
Unknown,Wire,WAnd,WOr,Tri,TriAnd,TriOr,Tri0,Tri1,TriReg,Supply0,
Supply1,UWire,Interconnect,UserDefined

[hailongSun2000]

Thanks for helping code review in advance 😃 !

[uenoku]

I have limited knowledge for Moore/Slang but this looks good to me 👍

[maerhart]

I'm not familiar with all the subtleties of SystemVerilog, but here are some of my thoughts/observations.

[cepheus69]

The portOp will be removed. New module Op would replace the original functionality of portOp

[fabianschuiki]

Cool! Thanks for pushing on this 👍 Added a few comments.

[cepheus69]

The netOp is mainly used for declaring NetKind elements in the module. The NetKind has: Unknown,Wire,WAnd,WOr,Tri,TriAnd,TriOr,Tri0,Tri1,TriReg,Supply0, Supply1,UWire,Interconnect,UserDefined

Mark Unknow Interconnect Userdefined as not support!

[fabianschuiki]

llvm_unreachable is weird in that it doesn't really print an error message in non-debug/non-assertion builds. It will just hint the compiler at this branch being unreachable in release builds. However, you do want to report an error to the user here. Something like the following:

static FailureOr<moore::NetKind> convertNetKind(slang::ast::NetType::NetKind kind, Location loc) {
  switch (kind) {
  // ...
  case slang::ast::NetType::Interconnect:
  case slang::ast::NetType::Unknown:
  case slang::ast::NetType::UserDefined:
    return mlir::emitError(loc, "unsupported net type `") << slang::ast::toString(kind) << "`";
  }
}

[fabianschuiki]

LGTM! Thanks 🥳

[cepheus69]

LGTM! Thanks 🥳

Thanks a lot !!! ❤️ The improved module & instance will be ready soon.