[ExportVerilog] Spill LTL operands used in event control if not allowed. #6829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disallowing expressions in "event control", also disallow the disable iff condition to be inlined.
fabianschuiki
approved these changes
Mar 14, 2024
seldridge
reviewed
Mar 14, 2024
seldridge
approved these changes
Mar 14, 2024
Walking users is just walking uses and having the iterator call getOwner() for you anyway, so just walk uses to make checking the operand simpler / more efficient / direct.
dtzSiFive
changed the title
fabianschuiki
approved these changes
Mar 14, 2024
seldridge
pushed a commit
that referenced
this pull request
Mar 14, 2024
…ed. (#6829) When disallowing expressions in "event control", also disallow the disable iff condition to be inlined and clock op's clock condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disallowing expressions in "event control", also disallow the disable iff condition to be inlined.
Do same for the clock op's clock operand.