[FIRRTL] Support alternative base paths in LowerClasses. #6817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm seems like some minor issue that I didn't see while working on this with an older LLVM version, I'll fix that. |
mikeurbach
force-pushed
the
mikeurbach/lower-classes-alt-base-path
branch
from
7bc4de5
to
27269f0
Compare
|
I don't know what's going on... I didn't see these errors locally 🤦 |
We previously had a constraint that paths are targeting entities in the same owning module as the path. This allowed us to assume that a single base path can be created for each owning module, and used in all paths. However, we have transforms that extract entities targeted by paths outside the paths' owning module. To support this, we can instead plumb through base paths created higher up in the instance graph down to the paths that need them. When a path is detected outside the owning module, we find the module in which the entity is instantiated and pass through its base path to the paths that reference the entity. Most of the work here is just plumbing, and the PathInfoTable has been extended with new data structures and functions to support this.
mikeurbach
force-pushed
the
mikeurbach/lower-classes-alt-base-path
branch
from
27269f0
to
3bd4a6d
Compare
rwy7
reviewed
Mar 13, 2024
Co-authored-by: Robert Young <rwy0717@gmail.com>
Co-authored-by: Prithayan Barua <prithayan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had a constraint that paths are targeting entities in the same owning module as the path. This allowed us to assume that a single base path can be created for each owning module, and used in all paths. However, we have transforms that extract entities targeted by paths outside the paths' owning module.
To support this, we can instead plumb through base paths created higher up in the instance graph down to the paths that need them. When a path is detected outside the owning module, we find the module in which the entity is instantiated and pass through its base path to the paths that reference the entity.
Most of the work here is just plumbing, and the PathInfoTable has been extended with new data structures and functions to support this.