Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Don't enforce owning module for local ref in LowerClasses. #6811

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[FIRRTL] Don't enforce owning module for local ref in LowerClasses. #6811

merged 1 commit into from
Mar 12, 2024

Commits on Mar 11, 2024

  1. [FIRRTL] Don't enforce owning module for local ref in LowerClasses. 

    We have an existing check that paths are in the same owning module as
the entity they target. This is absolutely required for hierarchical
references to compose with basepaths. However, we have legacy flows
that extract entities out of their owning module, and we want to be
able to target those things. This works around these conflicting
requirements by skipping the owning module check for local targets
only. This is safe because we still check such local targets are only
instantiated once, so there is no ambiguity even though they are not
instantiated within the owning module.
    @mikeurbach
    mikeurbach committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    acc9109 View commit details
    Browse the repository at this point in the history