Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Fix sign bit truncation in constant parser #6794

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[FIRRTL] Fix sign bit truncation in constant parser #6794

merged 1 commit into from
Mar 8, 2024

Commits on Mar 8, 2024

  1. [FIRRTL] Fix sign bit truncation in constant parser 

    Fix an issue in the parser of the `firrtl.constant` op, which would
truncate the sign bit of negative constants without reporting an error.
This would for example accept -2 as a valid 1-bit constant, truncating
the `...11111110` bit pattern to `0`.
    @fabianschuiki
    fabianschuiki committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    cd97a07 View commit details
    Browse the repository at this point in the history