[Emit] Group file header ops into emit.fragment
#6789
Conversation
nandor
force-pushed
the
dev/nandor/fragment
branch
2 times, most recently
from
e935c73
to
e37736d
Compare
nandor
force-pushed
the
dev/nandor/fragment
branch
from
e37736d
to
c49ee95
Compare
|
Thanks for the comments, addressed. |
| auto it = fragmentMapping.find(sym.getAttr()); | ||
| if (it == fragmentMapping.end()) { | ||
| encounteredError = true; | ||
| op->emitError("cannot find referenced fragment ") << sym; |
There was a problem hiding this comment.
Shouldn't this be caught during validation?
There was a problem hiding this comment.
Specifically the generic symbol use verifier from SymbolUserOpInterface
nandor
force-pushed
the
dev/nandor/fragment
branch
from
c49ee95
to
db9965c
Compare
|
This is a stopgap measure that improves replicated ops a bit to better group them until we sanitize the downstream flows sufficiently to be able to include them from a header, so I wouldn't want to make it a first-class attribute on modules, similarly to the |
There was a problem hiding this comment.
Let's get this unblocked. Sorry for the delay.
How is this being tested for the LowerToHW changes? Is there enough coverage already with end-to-end tests? I was surprised that this did not need changes to existing LowerToHW tests. Can you include some tests of this if it is not already covered.
nandor
force-pushed
the
dev/nandor/fragment
branch
3 times, most recently
from
ecf647d
to
dd122d7
Compare
Instead of using the replicated op mechanism, fragments of SV code which must precede certain modules are grouped into fragment ops. Modules which rely on them reference them through a `emit.fragment` attribute. The fragments are printed through ExportVerilog. Subsequent PRs will fully replace replaced ops using fragments.
nandor
force-pushed
the
dev/nandor/fragment
branch
from
dd122d7
to
495ede5
Compare
Instead of using the replicated op mechanism, fragments of SV code which must precede certain modules are grouped into fragment ops. Modules which rely on them reference them through a
emit.fragmentattribute. The fragments are printed through ExportVerilog.Subsequent PRs will fully replace replicated ops using fragments.