Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Comb] Handle type aliases in comb.concat #6588

Merged
merged 4 commits into from
Jan 19, 2024
Merged

[Comb] Handle type aliases in comb.concat #6588

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aad06b9
[Comb] Handle type aliases in `comb.concat`
hovind Jan 17, 2024
783d6e7
[Comb] Add regression test (#5772)
hovind Jan 18, 2024
81471d0
[Comb] Adhere to convention
hovind Jan 18, 2024
3817099
[Comb] Test for presence of `comb.concat` in output
hovind Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Comb] Test for presence of comb.concat in output
  • Loading branch information
@hovind
hovind committed Jan 18, 2024
commit 3817099160107d3f28b28b9c15a41867612cdb9c
1 change: 1 addition & 0 deletions test/Dialect/Comb/basic.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ hw.type_scope @__hw_typedecls {
// https://github.com/llvm/circt/issues/5772
// CHECK-LABEL: @Issue5772
hw.module @Issue5772(in %arg0: !hw.typealias<@__hw_typedecls::@foo,i1>) {
// CHECK: comb.concat %arg0 : !hw.typealias<@__hw_typedecls::@foo, i1>
%0 = comb.concat %arg0 : !hw.typealias<@__hw_typedecls::@foo,i1>
mikeurbach marked this conversation as resolved.
Show resolved Hide resolved
}