[NFC][ESI] Refactor runtime headers and design hierarchy #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teqdruid
commented
Dec 7, 2023
teqdruid
commented
- Rename Accelerator to what it really is: an AcceleratorConnection.
- Rename "Design" to "HWModule". Closer, but a slight overloading of terms.
- Add "Accelerator" as the root of a design hierarchy. It owns or shares ownership of everything "immortal".
teqdruid
force-pushed
the
dev/teqdruid/esi/runtime/ownership-refactor
branch
2 times, most recently
from
7f0727d
to
006e317
Compare
- Rename Accelerator to what it really is: an AcceleratorConnection. - Rename "Design" to "HWModule". Closer, but a slight overloading of terms. - Add "Accelerator" as the root of a design hierarchy. It owns or shares ownership of everything "immortal".
teqdruid
force-pushed
the
dev/teqdruid/esi/runtime/ownership-refactor
branch
from
006e317
to
fff6857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.