Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Add option to only mention existing files in HGLDD #6452

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

fabianschuiki
Copy link
Contributor

Add an option to HGLDD file emission to only consider location information in the IR if the corresponding file exists on disk. This can help filter out placeholder filenames such as <stdin> or <unknown>. Also add a corresponding --hgldd-only-existing-file-locs option to firtool.

Add an option to HGLDD file emission to only consider location
information in the IR if the corresponding file exists on disk. This can
help filter out placeholder filenames such as `<stdin>` or `<unknown>`.
Also add a corresponding `--hgldd-only-existing-file-locs` option to
firtool.
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@fabianschuiki fabianschuiki merged commit 0bc8055 into main Nov 30, 2023
4 checks passed
@fabianschuiki fabianschuiki deleted the fschuiki/hgldd-only-existing-files branch November 30, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants