[FIRRTL][LowerType] Handle unrealized_conversion_cast of other dialects #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prithayan
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
dtzSiFive
reviewed
Nov 16, 2023
| @@ -1334,6 +1334,10 @@ bool TypeLoweringVisitor::visitExpr(mlir::UnrealizedConversionCastOp op) { | |||
| return builder->create<mlir::UnrealizedConversionCastOp>(field.type, input) | |||
| .getResult(0); | |||
| }; | |||
| // If the input to the cast is an unknown type, getSubWhatever cannot handle | |||
| // it, donot lower the op. | |||
| if (!isa<FVectorType, BundleType, RefType>(op->getOperand(0).getType())) | |||
There was a problem hiding this comment.
I think it may be better to continue to error if we don't support lowering the thing if it's a FIRRTL type?
(only ignore if it's not a FIRRTL type, I mean)
Also I think this maybe should be using type_isa, e.g., !type_isa<FIRRTLType>(...)?
There was a problem hiding this comment.
Thanks @dtzSiFive , makes sense, this is required only for other dialects. Updated the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LowerTypes was crashing when lowering
unrealized_conversion_castfrom other dialects.This PR fixes the crash and ignores the cast op from other dialects instead of lowering them.