Update LLVM version to 34ddf0b2b040 #63
Conversation
|
Feel free to land these without review @stephenneuendorffer :) |
stephenneuendorffer
force-pushed
the
llvm-update
branch
from
ffb612d
to
fee2570
Compare
That was my plan but stuff is broken in the LLHDtoLLVM type conversion. It looks like the standard LLVM type converter is choking on an llhd.sig type whereas previously this passed through to the op conversion which handled the type conversion. @maerhart @fabianschuiki one of you is probably going to have to fix this up. |
stephenneuendorffer
force-pushed
the
llvm-update
branch
from
fee2570
to
c9abb9d
Compare
|
@rodonisi May I forward this to you as you are the author of the LLVM conversion pass? |
Yep, building LLVM right now. |
A small fixup is required to avoid conflicts between ODS-generated build methods because of default arguments. Also, since this keeps failing, I've updated the llvm cache so that it runs in a separate job. Otherwise the cache is not updated when the CIRCT build fails.
stephenneuendorffer
force-pushed
the
llvm-update
branch
from
c9abb9d
to
49c935f
Compare
Previously time constants were converted by their users, by creating a constant for each of the three time attributes. This makes time constants LLVM arrays containing the three time values instead, allowing more a more flexible use (e.g. passing time operands as block arguments). * Add time type conversion. * Add tme constants conversion. * Add time operands to the process persistence state. * Fix affected tests.
This works around the PartialConversion failing because of the introduction of (unused) `DialectCastOps`, that will be dealt with later during the full conversion.
|
@stephenneuendorffer I opened a PR on this branch of your fork which should be passing the tests. |
LLHDToLLVM fixes
Awesome! Thanks! |
A small fixup is required to avoid conflicts between ODS-generated build
methods because of default arguments.