[OM] Add location info to EvaluatorValue #6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
approved these changes
Oct 3, 2023
prithayan
force-pushed
the
dev/pbarua/om_location_info
branch
2 times, most recently
from
16e4084
to
8f66b61
Compare
mikeurbach
reviewed
Oct 4, 2023
prithayan
force-pushed
the
dev/pbarua/om_location_info
branch
from
8f66b61
to
1916916
Compare
mikeurbach
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
I'm still getting familiar with the latest refactor here to support graph regions, but I think this makes sense. Thanks for the iterations on this and dealing with the big refactor while this PR is in flight!
I would appreciate a second pair of eyes.. @uenoku do you mind taking a look?
| # CHECK: name: reference, field: ('Root', 'x') | ||
| print(f"name: {name}, field: {field}") | ||
| # CHECK-SAME: loc: loc("-":32:7) | ||
| #location from om.class.field @field, %param : !om.integer |
There was a problem hiding this comment.
extreme nit:
Suggested change
| #location from om.class.field @field, %param : !om.integer | |
| # location from om.class.field @field, %param : !om.integer |
uenoku
reviewed
Oct 9, 2023
Comment on lines
130
to
134
| : EvaluatorValue(attr.getContext(), Kind::Attr, | ||
| mlir::UnknownLoc::get(attr.getContext())), | ||
| attr(attr) { | ||
| markFullyEvaluated(); | ||
| } |
There was a problem hiding this comment.
Can we reuse AttributeValue(Attribute attr, Location loc) constructor?
uenoku
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the debug locations to the evaluator value, which will be used to generate
infofields of the object model output json.