[FIRRTL] Remove getBaseTypeOrNull
#5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngar
force-pushed
the
firrtl-prop-getbasetypeof
branch
from
6865b10
to
da3ec30
Compare
youngar
commented
Jun 13, 2023
youngar
force-pushed
the
firrtl-prop-getbasetypeof
branch
from
d904862
to
4dd8590
Compare
youngar
changed the title
getBaseTypeOrNull to getBaseTypeIfPresentgetBaseTypeOrNull
This changes `getBaseTypeOrNull` to accept a null type field and renames the function to `getBaseTypeIfPresent`. This aligns with upstream by making this family of function (`OrNull`) accept a null argument, and uses the newer naming to which makes this property more clear. There are no users of this function outside of FIRRTLUtils.h.
youngar
force-pushed
the
firrtl-prop-getbasetypeof
branch
from
4dd8590
to
6bec521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
getBaseTypehandles all types, there is no need forgetBaseTypeOrNull.