[SV] Added DPI import and call ops #4856
Draft
+510
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandor
force-pushed
the
dev/nandor/sv-dpi
branch
from
cab2b12
to
0a63652
Compare
darthscsi
reviewed
Mar 20, 2023
There was a problem hiding this comment.
It seems this is treating calls more like modules than functions. We do need to represent functions, it would be worth doing so now, rather than have to rip this out later.
A couple other things:
- I think output values from a call should be able to use the same forced-spilling code as modules use. I guess it's not as sometimes you use a reg. I assume that is because the output argument of a call is not a continuous assignment? But maybe not? "For output and inout arguments, the value propagation (i.e., value change events) happens as if an actual argument was assigned a formal argument immediately after control returns from imported functions." I can't tell from that if it's suppose to be blocking or non-blocking. Implicit sensitivity are function aware, fwiw.
- BPAssign probably shouldn't care what the source of a value is.
| @@ -3091,6 +3094,9 @@ LogicalResult StmtEmitter::visitSV(AssignOp op) { | |||
| } | |||
|
|
|||
| LogicalResult StmtEmitter::visitSV(BPAssignOp op) { | |||
| if (dyn_cast_or_null<DPICallOp>(op.getSrc().getDefiningOp())) | |||
There was a problem hiding this comment.
Can you assume that structs won't have accessors prior to assign?
|
I'll re-work this to separately indicate which arguments are inputs and outputs, requiring inout types for outputs. |
|
From talking to @nandor, will handle return types too and make calls expressions. Marking this draft for now. |
|
Is there any update on the DPI import and export functions? This is common used in the DV flow, wondering if there are outstanding work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces DPI import and call operations.
To import a function, the following can be declared at the module level:
sv.dpi.import @test(%arg0: i32) -> (res0: i5, res1: i6)This is hard-wire to contextual functions.
To call a function, an op can be added to procedural scopes.
%res0, %res1 = sv.dpi.call @test(%arg0) : (i32) -> (i5, i6)The emission is similar to instances. Temporary registers will be added to capture the results of DPI calls.
In the future, constraints should be relaxed to allow for return types and to place calls in arbitrary contexts.