[LowerToHW] Lower i0 operand in printf-encoded assertions to i1 #4311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Nov 15, 2022
dtzSiFive
approved these changes
Nov 15, 2022
| // CHECK-NEXT: [[TRUE:%.+]] = hw.constant true | ||
| // CHECK-NEXT: [[TMP1:%.+]] = comb.xor %enable, [[TRUE]] | ||
| // CHECK-NEXT: [[TMP2:%.+]] = comb.or bin [[TMP1]], %cond | ||
| // CHECK-NEXT: sv.assert.concurrent posedge %clock, [[TMP2]] message "assert0" | ||
| // CHECK-NEXT: sv.ifdef "USE_PROPERTY_AS_CONSTRAINT" { | ||
| // CHECK-NEXT: sv.assume.concurrent posedge %clock, [[TMP2]] | ||
| // CHECK-NEXT: } | ||
| firrtl.assert %clock, %cond, %enable, "assert1"(%value) : !firrtl.uint<42> {isConcurrent = true, format = "ifElseFatal"} | ||
| firrtl.assert %clock, %cond, %enable, "assert1"(%value, %i0) : !firrtl.uint<42>, !firrtl.uint<0> {isConcurrent = true, format = "ifElseFatal"} |
There was a problem hiding this comment.
Nit: Can this string be changed so "substitutions" are used? I know we don't inspect it presently, but as-is it doesn't seem entirely unreasonable to elide the substitutions as trivially unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports i0 value operand of verification statements. Following the implementation of printf, we use i1 value as a result.