Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance bitwise folders and add canonicalization patterns #43

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Enhance bitwise folders and add canonicalization patterns #43

merged 4 commits into from
Jul 20, 2020

Conversation

maerhart
Copy link
Member

  • Fold bitwise operations having complements as arguments
  • Fold double not
  • Convert xor with one operand being all ones to a not
  • Add equality operation canonicalization patterns
  • Move shift folding tests to new canonicalization directory
  • Merge old bitwise and arithmetic folding tests into new canonicalization test directory

@maerhart
Add folders for bitwise operations
fe62899 
* Fold bitwise operations having complements as arguments
* Fold double not
* Convert xor with one operand being all ones to a not
@maerhart
Add equality operation canonicalization patterns
7de69d6 
* Move shift folding tests to new canonicalization folder
* Merge old bitwise and arithmetic folding tests
@maerhart
Add newlines
01fbe46
@maerhart
clang-format
0515379
@maerhart maerhart added the LLHD label Jul 16, 2020
@maerhart
Copy link
Member Author

@rodonisi Your review is also very welcome, unfortunately, I cannot add you to the reviewers list directly.

@rodonisi
Copy link
Contributor

rodonisi commented Jul 19, 2020 •
edited
Loading

@rodonisi Your review is also very welcome, unfortunately, I cannot add you to the reviewers list directly.

I don't know if that's related, but I'll take this for a friendly ping, if someone could grand me write access to this repo, for assigning labels, reviewers, etc. in PRs? I think that flew under the radar in one of my previous PRs.

@stephenneuendorffer
Copy link
Contributor

@rodonisi Your review is also very welcome, unfortunately, I cannot add you to the reviewers list directly.

I don't know if that's related, but I'll take this for a friendly ping, if someone could grand me write access to this repo, for assigning labels, reviewers, etc. in PRs? I think that flew under the radar in one of my previous PRs.

I added you. Sorry it took so long!

@rodonisi
Copy link
Contributor

@rodonisi Your review is also very welcome, unfortunately, I cannot add you to the reviewers list directly.

I don't know if that's related, but I'll take this for a friendly ping, if someone could grand me write access to this repo, for assigning labels, reviewers, etc. in PRs? I think that flew under the radar in one of my previous PRs.

I added you. Sorry it took so long!

Thanks a lot, no problem at all!

@maerhart maerhart merged commit e6e0956 into llvm:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodonisi rodonisi rodonisi approved these changes

@stephenneuendorffer stephenneuendorffer stephenneuendorffer approved these changes

@lattner lattner Awaiting requested review from lattner

Assignees
No one assigned
Labels
LLHD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maerhart @rodonisi @stephenneuendorffer