[Handshake] Expose pass options in pass constructor

[Dinistro]

No description provided.

[mortbopet]

Do we need two separate constructors? Based on the following pattern, a single should be sufficient:

https://github.com/llvm/circt/blob/main/include/circt/Dialect/FIRRTL/Passes.h#L66-L69
and

circt/include/circt/Dialect/FIRRTL/Passes.td

Lines 152 to 166 in 32cc6af

	def CreateSiFiveMetadata : Pass<"firrtl-emit-metadata", "firrtl::CircuitOp"> {
	let summary = "Emit metadata of the FIRRTL modules";
	let description = [{
	This pass handles the emission of several different kinds of metadata.
	}];
	let constructor = "circt::firrtl::createCreateSiFiveMetadataPass()";
	let options = [Option<"replSeqMem", "repl-seq-mem", "bool", "false",
	"Lower the seq mem for macro replacement and emit relevant metadata">,
	Option<"replSeqMemCircuit", "repl-seq-mem-circuit", "std::string", "",
	"Circuit root for seq mem metadata">,
	Option<"replSeqMemFile", "repl-seq-mem-file", "std::string", "",
	"File to which emit seq meme metadata">
	];
	let dependentDialects = ["hw::HWDialect"];
	}

[Dinistro]

Duplicating the default arguments might not be the best idea, but we can change it. At some point, we will, either way, adopt the new mlir pass generation (#3962). This change will ensure that pass constructors are generated which take an option struct.

[mortbopet]

new mlir pass generation (#3962)

Awesome, that seems like the right solution. I'm good with this for now, assuming that we migrate over ASAP.