[LLHD] Add extract field operations #35
Conversation
* Add operations to statically and dynamically extract an element from a vector or tuple * They can also operate on signals by returning an alias signal to the specified element of the underlying type of the target signal, this means they don't perform any kind of probing like the llhd.prb instruction
| @@ -101,3 +101,118 @@ def LLHD_DextsOp : LLHD_Op<"dexts", [ | |||
| unsigned getTargetWidth() { return getLLHDTypeWidth(target().getType()); } | |||
| }]; | |||
| } | |||
|
|
|||
| def LLHD_ExtfOp : LLHD_Op<"extf", [ | |||
There was a problem hiding this comment.
prefer complete words. IS this "Extend Float?" "Extract field?" "External foobar?" "Example Tensorflow?"
| PredOpTrait<"'index' has to be smaller than the 'target' size", | ||
| CPred<"$index.cast<IntegerAttr>().getInt() < getTargetWidth()">>, | ||
| TypesMatchWith<"'result' type has to match type at 'index' of 'target', in " | ||
| "case 'target' is a singal, consider the underlying types of the 'target'" |
There was a problem hiding this comment.
singal -> signal
| NoSideEffect, | ||
| PredOpTrait<"'index' has to be smaller than the 'target' size", | ||
| CPred<"$index.cast<IntegerAttr>().getInt() < getTargetWidth()">>, | ||
| TypesMatchWith<"'result' type has to match type at 'index' of 'target', in " |
There was a problem hiding this comment.
This seems awkwardly worded to me. The description doesn't quite seem to match the predicate?
| "getElementTypeAtIndex($index.cast<IntegerAttr>().getInt())) " | ||
| ": getElementTypeAtIndex($index.cast<IntegerAttr>().getInt()))"> | ||
| ]> { | ||
| let summary = "Extract an element from a vector or tuple"; |
There was a problem hiding this comment.
or a signal with with vector or tuple type?
| }]; | ||
| } | ||
|
|
||
| def LLHD_DextfOp : LLHD_Op<"dextf", [ |
There was a problem hiding this comment.
Oh no, it's random sequence of letters op!
* llhd.extf -> llhd.extract_element * llhd.dextf -> llhd.dyn_extract_element
|
@stephenneuendorffer Thanks for your review! I renamed |
Sounds good I think. |
a vector or tuple
specified element of the underlying type of the target signal, this
means they don't perform any kind of probing like the llhd.prb
instruction