Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HandshakeToFIRRTL] Add top module inference and instance cycle detection #2056

Merged
merged 4 commits into from
Nov 1, 2021
Merged

[HandshakeToFIRRTL] Add top module inference and instance cycle detection #2056

merged 4 commits into from
Nov 1, 2021

Commits on Oct 29, 2021

  1. [HandshakeToFIRRTL] Add top module inference and instance cycle detec… 

    …tion

In preparation for supporting `handshake.instance` lowering, this commit introduces top module inference and instance cycle detection. The IR is topologically sorted based on `handshake.instance` usage. During this, we check for instance cycles (and report them to the user) as well as top-module detection. For now, if multiple top modules are available, an error is thrown.

Furthermore, the `firrtl.circuit` op is now created outside of the `handshake.func` operation lowering, based on the inferred top-level name.
    @mortbopet
    mortbopet committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    8444c68 View commit details
    Browse the repository at this point in the history

  2. small comment

    @mortbopet
    mortbopet committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    11f45bf View commit details
    Browse the repository at this point in the history

  3. small edit

    @mortbopet
    mortbopet committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    79d48f2 View commit details
    Browse the repository at this point in the history

  4. Name change in error message

    @mortbopet
    mortbopet committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    7aceb48 View commit details
    Browse the repository at this point in the history