[Handshake] Persist handshake.FuncOp argument names #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
approved these changes
Oct 28, 2021
This commit modifies the parsing of `handshake.func` operations to store the SSA argument names as a new attribute `argNames`. This attribute is then later used in `handshakeToFIRRTL` to guide argument naming. This, unfortunately, does not solve how to persist names from `standard`->`handshake` - a `builtin.func` does not persist parsed SSA names. For reference, these are discarded at this point: https://github.com/llvm/llvm-project/blob/main/mlir/lib/IR/BuiltinDialect.cpp#L116-L119 If provided, an `argNames` attribute set for a `builtin.func` will be copied to the `handshake.func` during `StandardToHandshake`.
mortbopet
force-pushed
the
handshake/better_names
branch
from
e422c63
to
ed23040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the parsing of
handshake.funcoperations to store the SSA argument names as a new attributeargNames. This attribute is then later used inhandshakeToFIRRTLto guide argument naming. This follows how FIRRTL and Calyx implement argument naming.This, unfortunately, does not solve how to persist names from
standard->handshake- abuiltin.funcdoes not persist parsed SSA names so i've yet to figure out a method of doing this without requiring a change to the parser ofbuiltin.func.If provided, an
argNamesattribute set for abuiltin.funcwill be copied to thehandshake.funcduringStandardToHandshakeso that is a halfway-solution for driving naming from abuiltin.funclevel.