Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Handshake] Improve handshake .dot graph output #2038

Merged
merged 3 commits into from
Oct 27, 2021
Merged

[Handshake] Improve handshake .dot graph output #2038

merged 3 commits into from
Oct 27, 2021

Conversation

mortbopet
Copy link
Contributor

This commit improves the handshake .dot graph output, making it quite a bit easier to visually parse.

Old graph:
image

New graph:
image

stephenneuendorffer
stephenneuendorffer approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@stephenneuendorffer stephenneuendorffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mortbopet mortbopet merged commit 6628939 into llvm:main Oct 27, 2021
@mortbopet mortbopet deleted the handshake/better_xdot branch October 28, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenneuendorffer stephenneuendorffer stephenneuendorffer approved these changes

@mikeurbach mikeurbach Awaiting requested review from mikeurbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortbopet @stephenneuendorffer