Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Add GCT Data/Mem Tap Prefixing to PrefixModules #2031

Merged
merged 2 commits into from
Oct 26, 2021

Commits on Oct 25, 2021

  1. [FIRRTL] Prefix GCT Data/Mem Taps in PrefixModules

    Change PrefixModules to rename external modules that are Grand Central
    data or memory taps.  External modules that have more than one prefix
    will be cloned ("duplicated" in Scala FIRRTL Compiler terminology) to
    create new external modules for prefixes after the first.  This is the
    same behavior as how PrefixModules works for non-external modules.
    
    Note: it is unexpected that Grand Central will produce (or work?) with
    multiply instantiated Data/Mem taps.  However, the behavior added here
    is sane.
    
    This change aligns the prefixing behavior of CIRCT with the Scala FIRRTL
    Compiler for Grand Central Data/Mem taps.
    
    Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
    seldridge committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    0ac2cca View commit details
    Browse the repository at this point in the history
  2. [FIRRTL] Test PrefixModules GCT Data/Mem Taps, NFC

    Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
    seldridge committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    fa52bf6 View commit details
    Browse the repository at this point in the history