[FIRRTL] Update NLA during prefix module pass #2030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
NonLocalAnchor
symbol reference to modules that are renamed in prefix module pass.The
nla
op contains reference to module symbols, which might be left invalid after module renaming.firrtl.nla @nla_2 [@Top, @Aardvark, @Zebra] ["test", "test", "Zebra"]
There can be multiple copies of any module created after the prefix module pass.
The
firrtl.nla
renaming is context sensitive and depends on the instance op, which is anchored to thenla
.This renaming is also based on the assumption, that the modules in the
firrtl.nla
begin with the top level module.Otherwise, the
firrtl.nla
might be ambiguous if multiple clones of the first module is created.This change is required for
OMIR
emission, since prefix module pass leaves the trackerfirrtl.nla
in invalid state.