[FIRRTL][OMIR] Add omir output file option to firtool. NFC. #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prithayan
changed the title
seldridge
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
This looks sane. (Also this fixes an issue where I've been manually writing the annotation in order to test these PRs. 😂 )
One consideration: currently the behavior in the pass is to use the OMIRFileAnnotation if no pass option was provided. I'd propose changing that (follow-up patch is fine) so that that case is an error. Specifying both --output-omir and OMIRFileAnnotation should be an error, IMO.
|
Thanks @seldridge , Will merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the option
output-omirto specify the output file for OMIR output json.