Skip to content

Commit

Permalink
[FIRRTL] Touchup {parse,emit}-basic.fir for --parse-only. (#7397)
Browse files Browse the repository at this point in the history
Minor tweaks to the FIRRTL/IR so that it's legal
enough to survive `--parse-only`.

"OMDeleted" -> "OMDeleted:"
Fixup intrinsic signature.
  • Loading branch information
dtzSiFive authored Jul 29, 2024
1 parent 759ef12 commit 01d98e8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions test/Dialect/FIRRTL/emit-basic.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -655,8 +655,8 @@ firrtl.circuit "Foo" {
%d = firrtl.double 0.333333333333333333333333333333333333333
firrtl.propassign %double, %d : !firrtl.double

// CHECK: propassign path, path("OMDeleted")
%p = firrtl.unresolved_path "OMDeleted"
// CHECK: propassign path, path("OMDeleted:")
%p = firrtl.unresolved_path "OMDeleted:"
firrtl.propassign %path, %p : !firrtl.path

// CHECK: propassign list,
Expand Down
8 changes: 4 additions & 4 deletions test/Dialect/FIRRTL/parse-basic.fir
Original file line number Diff line number Diff line change
Expand Up @@ -1576,9 +1576,9 @@ circuit BasicProps :
module Path :
; CHECK-SAME: out %path: !firrtl.path
output path : Path
; CHECK: firrtl.unresolved_path "OMDeleted"
; CHECK: firrtl.unresolved_path "OMDeleted:"
; CHECK: firrtl.propassign %path, %0 : !firrtl.path
propassign path, path("OMDeleted")
propassign path, path("OMDeleted:")

; CHECK-LABEL: firrtl.class private @SimpleClass(in %a: !firrtl.string, out %b: !firrtl.string) {
; CHECK-NEXT: firrtl.propassign %b, %a : !firrtl.string
Expand Down Expand Up @@ -1895,9 +1895,9 @@ circuit GenericIntrinsics:
; CHECK-NEXT: %[[PAV:.+]] = firrtl.int.generic "circt_plusargs_value" <FORMAT: none = "foo"> : () -> !firrtl.bundle<found: uint<1>, result: uint<5>>
; CHECK-NEXT: %n = firrtl.node interesting_name %[[PAV]]
node n = intrinsic(circt_plusargs_value<FORMAT = "foo"> : { found : UInt<1>, result : UInt<5> })
; CHECK-NEXT: %[[PAT:.+]] = firrtl.int.generic "circt_plusargs_test" <FORMAT: none = "bar"> : () -> !firrtl.uint<3>
; CHECK-NEXT: %[[PAT:.+]] = firrtl.int.generic "circt_plusargs_test" <FORMAT: none = "bar"> : () -> !firrtl.uint<1>
; CHECK-NEXT: %n2 = firrtl.node interesting_name %[[PAT]]
node n2 = intrinsic(circt_plusargs_test<FORMAT = "bar"> : UInt<3>)
node n2 = intrinsic(circt_plusargs_test<FORMAT = "bar"> : UInt<1>)


; Statement with unused return value.
Expand Down

0 comments on commit 01d98e8

Please sign in to comment.