Spack 1.1 & TPL v2025.12.0 updates #1769

bmhan12 · 2026-01-12T19:14:01Z

This PR:

Updates Spack to 1.1
Updates the RAJA suite of packages to v2025.12.x
- Updates Docker images

TODO:

Fix Windows x64 builds (fails to compile with RAJA)
- ~~Latest attempt: https://github.com/llnl/axom/actions/runs/20835993048~~
- Bypass error by disabling openmp. Latest run: https://github.com/llnl/axom/actions/runs/21222202624

bmhan12 · 2026-01-12T19:16:45Z

scripts/spack/packages/axom/package.py

            hip_link_flags = ""

-            rocm_root = os.path.dirname(spec["llvm-amdgpu"].prefix)
+            rocm_root = spec["llvm-amdgpu"].prefix


Here and in toss_4_x86_64_ib_cray/spack.yaml, I incorporated changes from @adrienbernede 's PR #1739 to get things working with Spack 1.1 .

bmhan12 · 2026-01-12T19:19:29Z

scripts/vcpkg_ports/raja/vcpkg_raja_openmp.patch

+// Include OpenMP header for Windows
+#if defined(_OPENMP)
+#include <omp.h>
+#endif


This patch file is part of my attempt to get raja v25.12.0 working with Windows.

Following error without this patch:

D:\a\axom\axom\uberenv_libs\vcpkg\buildtrees\raja\src\v2025.12.0-beae201c76.clean\include\RAJA/policy/openmp/thread.hpp(35): error C3861: 'omp_get_max_threads': identifier not found D:\a\axom\axom\uberenv_libs\vcpkg\buildtrees\raja\src\v2025.12.0-beae201c76.clean\include\RAJA/policy/openmp/thread.hpp(41): error C3861: 'omp_get_thread_num': identifier not found

bmhan12 · 2026-01-13T16:33:08Z

Additional context from testing:

On Windows, I've tried building RAJA v2025.12.0 and v2025.09.1 (current version is v2025.09.0), both fail during compilation of Axom with the errors:

D:\a\axom\axom\uberenv_libs\vcpkg\installed\x64-windows\include\RAJA\policy\openmp\forall.hpp(93,5): error C3001: 'declare': expected an OpenMP directive name...
D:\a\axom\axom\uberenv_libs\vcpkg\installed\x64-windows\include\RAJA\policy\openmp\forall.hpp(98,27): error C3036: 'combine': invalid operator token in OpenMP 'reduction' clause...

EDIT: Between v2025.09.0 and v2025.09.1, this seems to be the most relevant PR to openmp changes? llnl/RAJA#1884

rhornung67 · 2026-01-13T17:29:35Z

@bmhan12 to be clear: it works with RAJA 2025.09.0 and breaks with RAJA 2025.09.1 and newer?

bmhan12 · 2026-01-13T17:31:11Z

@bmhan12 to be clear: it works with RAJA 2025.09.0 and breaks with RAJA 2025.09.1 and newer?

Yes.

rhornung67 · 2026-01-13T18:12:06Z

@bmhan12 to be clear: it works with RAJA 2025.09.0 and breaks with RAJA 2025.09.1 and newer?

Yes.

Thank you. I've got John looking into it. His RAJA PR seems to be the cause of the breakage.

bmhan12 · 2026-01-21T22:43:15Z

scripts/vcpkg_ports/axom/vcpkg.json

    "conduit",
    "lua",
    "mfem",
-    "openmp",


After talking with @kennyweiss, I decided we can disable OpenMP on Windows for now, and can enable it again at a later date.

It was also mentioned that Umpire is actually disabled in our Windows testing, I left a comment in this file to track these changes.

Tag: @johnbowen42

adrienbernede · 2026-01-22T14:43:39Z

scripts/spack/configs/versions.yaml

  umpire:
    require:
-      - spec: "@2025.09.0"
+      - spec: "@git.0372fbd6e1f17d7e6dd72693f8b857f3ec7559e9=develop"


Why use the commit here compared to the version tag ?

2025.12.0 isn't in upstream spack yet, so I went with the commit hash.

adrienbernede · 2026-01-22T14:45:22Z

scripts/spack/configs/toss_4_x86_64_ib/spack.yaml

      buildable: false
      externals:
-      - spec: mvapich2@2.3.7.clang_19~alloca~cuda~debug~hwloc_graphics~hwlocv2+regcache+wrapperrpath build_system=autotools ch3_rank_bits=32 fabrics=mrail file_systems=auto process_managers=slurm threads=multiple
+      - spec: mvapich2@2.3.7.clang_19~alloca~cuda~debug~hwloc_graphics~hwlocv2+regcache+wrapperrpath ch3_rank_bits=32 fabrics=mrail file_systems=auto process_managers=slurm threads=multiple


I'm curious how you verify those variants for external installs. Are they provided by the spack external detection tool ?

Yes, that is where I originally got all these variants, using spack to detect them.
Turns out this is probably not the best idea, since the packages and detection can change between Spack versions.

You actually don't need all the variants anymore. It was needed when you couldn't specify which mvapich you needed per compiler before toolchains. Basically we were forcing the concretizer to select the right one. You can do this now:

https://github.com/llnl/smith/blob/c00589ac9cb73deb2fe4d810f3f98b63aa2948e6/scripts/spack/configs/toss_4_x86_64_ib/spack.yaml#L94-L100

https://github.com/llnl/smith/blob/c00589ac9cb73deb2fe4d810f3f98b63aa2948e6/scripts/spack/configs/toss_4_x86_64_ib/spack.yaml#L28-L29

@white238 so is just the version sufficient now for externals?

yes, as long as you specify it in the toolchain

rhornung67

Thank you for working through this stuff @bmhan12 LGTM!

Co-authored-by: Adrien M. Bernede <bernede1@llnl.gov>

bmhan12 added TPL Issues related to Axom's third party libraries Testing Issues related to testing Axom Build system Issues related to Axom's build system labels Jan 12, 2026

bmhan12 commented Jan 12, 2026

View reviewed changes

bmhan12 force-pushed the feature/han12/spack_12_25 branch 2 times, most recently from b1ced68 to 2b540e7 Compare January 12, 2026 23:08

bmhan12 force-pushed the feature/han12/spack_12_25 branch 2 times, most recently from 2e8ff18 to 6c57b7f Compare January 13, 2026 16:50

bmhan12 force-pushed the feature/han12/spack_12_25 branch 4 times, most recently from 9f2f2dc to ea0f6f7 Compare January 16, 2026 15:48

bmhan12 mentioned this pull request Jan 20, 2026

bugfix: Fix axom's MSVC with OpenMP build llnl/RAJA#1977

Merged

bmhan12 force-pushed the feature/han12/spack_12_25 branch 4 times, most recently from 6358442 to a2c6564 Compare January 21, 2026 16:02

bmhan12 marked this pull request as ready for review January 21, 2026 22:38

bmhan12 commented Jan 21, 2026

View reviewed changes

bmhan12 requested review from jcs15c, kennyweiss, nselliott, publixsubfan, rhornung67 and white238 January 21, 2026 22:43

bmhan12 requested review from Arlie-Capps and gunney1 January 21, 2026 22:43

Arlie-Capps approved these changes Jan 21, 2026

View reviewed changes

adrienbernede approved these changes Jan 22, 2026

View reviewed changes

rhornung67 reviewed Jan 22, 2026

View reviewed changes

bmhan12 and others added 22 commits January 23, 2026 08:37

try newer camp/raja/umpire

2523dc6

Bump spack to 1.1.0 and newer spack_packages commit

2d646e4

Debugging odd autotools error, scr scheduler variant failure fix

3869bc0

fortran +rocm flag reorg, use rocm path sans llvm

f9ec254

Co-authored-by: Adrien M. Bernede <bernede1@llnl.gov>

Update vcpkg versions for blt/raja/umpire/camp

f1f2098

Try to patch RAJA for Windows OpenMP error

84184cd

Try using openmp:experimental for OpenMP SIMD features

effd7a2

Indentation for compiler flags for Docker spack.yaml

632db75

Try specifying python external for docker

47ea986

Updated rz host-configs

399b1cd

Update CZ host-configs

4612d7d

update Docker host-configs

f1eb69f

Update tpl hash for GHA

3f248d6

Update notes

42d1ed8

minute adjustment

67cd160

Testing - try raja v2025.09.1

e2a9ca4

Sanity check - Try pre-existing raja v2025.09.0

f93cc97

Test verbose raja v2025.12.0 ; Test just one job

abb23be

Test out msvc bugfix

539b778

Test all Windows jobs - cleanup openmp experimental testing

a2963ad

Test ~openmp; try add comments to JSON about defaults/variants

f54413f

Remove patch files used to test raja branch

9b928ef

bmhan12 force-pushed the feature/han12/spack_12_25 branch from c85da13 to 9b928ef Compare January 23, 2026 16:38

bmhan12 merged commit e498417 into develop Jan 23, 2026
15 checks passed

bmhan12 deleted the feature/han12/spack_12_25 branch January 23, 2026 21:03

Spack 1.1 & TPL v2025.12.0 updates #1769

Spack 1.1 & TPL v2025.12.0 updates #1769

Uh oh!

Conversation

bmhan12 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmhan12 commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhornung67 commented Jan 13, 2026

Uh oh!

bmhan12 commented Jan 13, 2026

Uh oh!

rhornung67 commented Jan 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rhornung67 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bmhan12 commented Jan 12, 2026 •

edited

Loading

bmhan12 commented Jan 13, 2026 •

edited

Loading