cpp 17: Simplify CUDA, HIP, and OpenMP forall implementations with if constexpr #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
solves #1877 |
trws
approved these changes
Aug 19, 2025
Member
trws
left a comment
trws
left a comment
There was a problem hiding this comment.
I love this kind of PR, good stuff.
I notice some of the OpenMP stuff is still duplicated, if the compilers support it those could be collapsed out with metadirective too but this is great. 👍
johnbowen42
force-pushed
the
feature/bowen/simplify-forall-param-pack-constexpr-if
branch
from
9ecde55 to
1b4593e
Compare
johnbowen42
deleted the
feature/bowen/simplify-forall-param-pack-constexpr-if
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies forall implementations by using if constexpr. Specifically, SFINAE overloads for empty/nonempty forall param packs are removed from CUDA and HIP, because we can use
if constexprto conditionally init/combine/resolve/ param packs. For OpenMP, a few other SFINAE overloads are simplified as well