Skip to content

Support wd_on_output for DoRA#2856

Merged
catboxanon merged 2 commits intomainfrom
unknown repository
May 5, 2025
Merged

Support wd_on_output for DoRA#2856
catboxanon merged 2 commits intomainfrom
unknown repository

Conversation

@67372a
Copy link
Contributor

@67372a 67372a commented May 4, 2025

  • Adds backwards compatible support to DoRA for wd_on_output, i.e. matching the original DoRA implementation from the paper.

Based off https://github.com/comfyanonymous/ComfyUI/blob/80a44b97f5cbcb890896e2b9e65d177f1ac6a588/comfy/weight_adapter/base.py#L42

Original PR
Comfy-Org/ComfyUI#7727

@67372a 67372a requested a review from lllyasviel as a code owner May 4, 2025 18:43
@67372a 67372a marked this pull request as draft May 4, 2025 21:56
@67372a 67372a marked this pull request as ready for review May 4, 2025 22:01
@catboxanon catboxanon merged commit 0ced1d0 into lllyasviel:main May 5, 2025
spawner1145 added a commit to spawner1145/stable-diffusion-webui-forge that referenced this pull request May 5, 2025
lshqqytiger pushed a commit to lshqqytiger/stable-diffusion-webui-amdgpu-forge that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants