Correct DoRA implementation with backward compatibility#7727
Merged
comfyanonymous merged 1 commit intoComfy-Org:masterfrom Apr 22, 2025
Merged
Correct DoRA implementation with backward compatibility#7727comfyanonymous merged 1 commit intoComfy-Org:masterfrom
comfyanonymous merged 1 commit intoComfy-Org:masterfrom
Conversation
67372a
added a commit
to 67372a/stable-diffusion-webui-reForge
that referenced
this pull request
Apr 27, 2025
Correct DoRA implementation with backward compatibility Based on Comfy-Org/ComfyUI#7727
This was referenced Apr 27, 2025
67372a
added a commit
to 67372a/stable-diffusion-webui-reForge
that referenced
this pull request
Apr 27, 2025
Based on: Comfy-Org/ComfyUI#7727 Comfy-Org/ComfyUI#7725 Comfy-Org/ComfyUI#7540 Backwards compatible support of wd on output Unified weight adapter solution Support for OFT/BOFT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow #7602 but with backward compatibiltiy
Also I added an eps value to avoid "possible" inf (which eventually cause NaN)