Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prompt translation #1039

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add prompt translation #1039

wants to merge 7 commits into from

Conversation

mashb1t
Copy link
Collaborator

@mashb1t mashb1t commented Nov 25, 2023 •
edited
Loading

Fixes #983
Fixes #1024

It's currently not possible to use the latest version of https://pypi.org/project/translators/ (5.8.9) without updating tqdm or using the latest compatible version (5.6.0), so i updated tqdm to 4.65.0.
As of the changelog https://tqdm.github.io/releases/ there are no breaking changes, but it would also be sufficient to use translators==5.6.0.

The conflict is caused by:
    The user requested tqdm==4.64.1
    transformers 4.30.2 depends on tqdm>=4.27
    pytorch-lightning 1.9.4 depends on tqdm>=4.57.0
    translators 5.8.9 depends on tqdm>=4.65.0

@mashb1t mashb1t requested a review from lllyasviel as a code owner November 25, 2023 22:37
@mashb1t
update tqdm to 4.65.0 to be able to use translators==5.8.9
29d1c3e 
this commit is optional and can be reverted
@mashb1t
move import as it checks for users ip and geolocation
8718e80 
Only metadata of users who specifically activated the prompt translate checkbox should be requested.
This also prevented users with adblockers on DNS level from being able to generate images, now fixed.
@mashb1t
Merge remote-tracking branch 'upstream/main' into feature/add-prompt-…
5cbf7f9 
…translate

# Conflicts:
#	requirements_versions.txt
@mashb1t
add translation for translate prompts info text
8e60550
@mashb1t mashb1t mentioned this pull request Dec 29, 2023
Closed
@mashb1t mashb1t added the i18n This has to do with translations label Jan 6, 2024
@mashb1t mashb1t mentioned this pull request Jan 22, 2024
Closed
@mashb1t mashb1t added Size M medium change, isolated, testing with care package change This PR introduces changes to packages labels Feb 9, 2024
@mashb1t mashb1t mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lllyasviel lllyasviel Awaiting requested review from lllyasviel lllyasviel is a code owner

Assignees
No one assigned
Labels
i18n This has to do with translations package change This PR introduces changes to packages Size M medium change, isolated, testing with care
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-language input support like DALL·E 3 【translators】add translators
1 participant
@mashb1t