Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute encoding #180

Merged
merged 1 commit into from
May 9, 2024
Merged

Fix attribute encoding #180

merged 1 commit into from
May 9, 2024

Conversation

bcardarella
Copy link
Contributor

Ensure deep map encodings

Ensure deep map encodings
@bcardarella
Copy link
Contributor Author

bcardarella commented May 7, 2024

@carson-katri please note this change, the following:

<FooBar data={%{
  a: 1,
  b: 2
}} />

no longer encodes as: <FooBar data="{\"a\":1,\"b":2}" />

It will encode HTML entities so this will be: <FooBar data="{&quot;a&quot;:1,&quot;b&quot;:2}"/>

Any HTML decoder should decode the string just fine.

@bcardarella bcardarella merged commit a310ad6 into main May 9, 2024
1 check passed
@bcardarella bcardarella deleted the bc-fix-attr-encoding branch May 9, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant