Merge pull request #180 from liveview-native/bc-fix-attr-encoding

Fix attribute encoding

lib/live_view_native/template/safe.ex

@@ -13,19 +13,7 @@ defimpl LiveViewNative.Template.Safe, for: [List, Map] do
   def to_iodata(data) do
     data
     |> Jason.encode!()
-    |> escape()
-  end
-
-  defp escape(<<?"::utf8, rest::bits>>) do
-    [~S(\") | escape(rest)]
-  end
-
-  defp escape(<<char::utf8, rest::bits>>) do
-    [char | escape(rest)]
-  end
-
-  defp escape(<<>>) do
-    []
+    |> Phoenix.HTML.Engine.html_escape()
   end
 end
 

test/live_view_native/template_test.exs

@@ -79,12 +79,19 @@ defmodule LiveViewNative.TemplateTest do
     end
 
     test "json encode maps" do
-      assigns = %{}
+      assigns = %{
+        data: %{"a" => %{"b" => 1}, "c" => [1, 2]}
+      }
 
-      assert ~LVN"""
-      <Foo data={%{a: 1}} b="asf" c={123} />
-      """
-      |> render() =~ ~S(<Foo data="{\"a\":1}" b="asf" c="123"></Foo>)
+      doc =
+        ~LVN"""
+        <Foo data={@data} d="asf" e={123} />
+        """
+        |> render()
+        |> Floki.parse_document!()
+
+      [json_data] = Floki.attribute(doc, "data")
+      assert assigns.data == Jason.decode!(json_data)
     end
 
     test "json encode list" do