Main thread isolation in VideoView #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
pblazej
commented
Apr 4, 2025
| @@ -285,7 +285,7 @@ public class VideoView: NativeView, Loggable { | |||
|
|
|||
| // Enter .main only if UI updates are required | |||
| if trackDidUpdate || shouldRenderDidUpdate || renderModeDidUpdate { | |||
| self.mainSyncOrAsync { | |||
| self.mainSyncOrAsync { @MainActor in | |||
There was a problem hiding this comment.
This MainActor is necessary only for <5.9 due to lack of assumeIsolate as you see below 🫳
hiroshihorie
approved these changes
Apr 4, 2025
I used Xcode 16.2 with Package 6.0 - every video track publish will fail 💣 |
|
@hiroshihorie still unable to pull that one |
I haven't pushed that pod lib yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny change, but prevents a crash in
.v6mode by fixing an important inconsistency.OnDidMutateis called within the critical section - so from any threadSendableclasses, it doesn't make much difference though@MainActormethods likemainSyncOrAsyncit does, as they:@MainActorisolatedSo the idea is
mainSyncOrAsyncsignature now reflects what really happens here:nonisolateditself as it's called from a@SendableOnDidMutate💚@MainActor💚The crash will happen during video track publication, the stack trace is pretty clear: