-
Notifications
You must be signed in to change notification settings - Fork 135
Speed up publish negotiation #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to
refer to the manpage for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
// Concurrent | ||
async let trackInfoPromise = addTrackFunc() | ||
async let negotiatePromise: () = negotiateFunc() | ||
let (trackInfo, _) = try await (trackInfoPromise, negotiatePromise) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pity we don't pass anything between these methods to enforce the dependency (kind of key-lock pattern), otherwise LGTM 👍
BTW @hiroshihorie I found another blocker → here's the fix #659 |
When enabled by server, we don't need to wait for AddTrackRequest to return so we can negotiate concurrently.
Reference:
livekit/client-sdk-android#612
livekit/client-sdk-js#1228
livekit/client-sdk-js#1231