Skip to content

Full reconnect on n/w path changes #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pblazej
Copy link
Contributor

@pblazej pblazej commented Apr 2, 2025

This is a high-level solution - without changing any logic for the reconnect itself 🤔

  • .quick cannot recover from "no connectivity" state
  • ConnectivityListenerDelegate was basically unused
  • There's StartReconnectReason.networkSwitch, but do we need an explicit startReconnect() here?
    • it will be triggered anyway, either by .websocket or .transport, we'll just hit the same state twice (with an error)

At least 2 scenarios to reproduce:

  • Use local server and disable wi-fi
  • Use any server with ✈️ mode (this is more likely to fail)

I'm still not sure how much ConnectOptions (timeouts) affect this case, does it work based on a "happy configuration"?

Copy link

ilo-nanpa bot commented Apr 2, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@pblazej pblazej requested a review from hiroshihorie April 2, 2025 10:10
@pblazej
Copy link
Contributor Author

pblazej commented Apr 22, 2025

Closing for now, in favor of #664 and further improvements in this area.

@pblazej pblazej closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant