Computed retry delay #664
Merged
Computed retry delay #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
pblazej
reviewed
Apr 8, 2025
| // First two attempts use fixed delay (0ms, 300ms) | ||
| return attempt == 0 ? 0 : baseDelay | ||
| } else if attempt < 5 { | ||
| // Next 3 attempts use exponential backoff with optional jitter |
pblazej
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More sensible retry delay defaults, adopted from the JS SDK.
This pull request focuses on improving the reconnect delay logic in the LiveKit SDK. The main changes include the introduction of a more sophisticated delay computation method, updates to the reconnect options, and enhancements to logging for better traceability.
Improvements to reconnect delay logic:
.nanpa/improve-reconnect-delay-logic.kdl: Added a patch to improve reconnect delay logic.Sources/LiveKit/Core/Room+Engine.swift: Modified the retry mechanism to use a computed reconnect delay with jitter and updated logging to reflect these changes. [1] [2] [3]Sources/LiveKit/Extensions/TimeInterval.swift: Introduced new constants for reconnect delays and a new methodcomputeReconnectDelayto calculate delays based on an ease-out curve with optional jitter. [1] [2]Enhancements to reconnect options:
Sources/LiveKit/Types/Options/ConnectOptions+Copy.swift: AddedreconnectMaxDelayto thecopyWithmethod to allow copying this new option.Sources/LiveKit/Types/Options/ConnectOptions.swift: UpdatedConnectOptionsto includereconnectMaxDelay, adjusted the default values, and ensured the maximum delay is respected. [1] [2] [3] [4] [5] [6]Enhancements to retry mechanism:
Sources/LiveKit/Support/AsyncRetry.swift: Updated the retrying logic to accept a closure for dynamic delay computation and adjusted logging to reflect the computed delays.