Make "connected to" log show up after every join, not just after fresh connections

[1egoman]

Previously, the code roughly did this:

// in Room.connectSignal:
const joinResponse = await engine.join(/* ... */);

this.serverInfo = /* computed from joinResponse */;

this.log.debug('connected to Livekit Server ... (with this.serverInfo data in here)'); 

This meant that the connected to Livekit Server ... log would log only on connect, not for reconnects.

So instead, I moved the log one level deeper, into RTCEngine.join:

// in RTCEngine.join:
// (preexisting join logic unchanged, joinResponse still comes from lower level this.client.join call)
const serverInfo = /* computed from joinResponse */;
this.log.debug('connected to Livekit Server ... (with serverInfo data in here)'); 
return { joinResponse, serverInfo };

// in Room.connectSignal:
const { joinResponse, serverInfo } = await engine.join(/* ... */);
this.serverInfo = serverInfo;
// (Log not here anymore)

With this change, the log shows up anytime a join occurs, whether it be fresh or for a reconnect. And the log still shows up in the same place on a fresh connect so the existing behavior should remain the same.

@boks1971 Does this address your concern? Is there a need to somehow disambiguate the log that is shown to determine if it is from a fresh connect or some type of reconnect, or is the context before / after the log good enough to tell this?

[changeset-bot]

🦋 Changeset detected

Latest commit: e2912a1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/livekit-client.esm.mjs	95.35 KB (+0.12% 🔺)
dist/livekit-client.umd.js	104.19 KB (-0.04% 🔽)

[boks1971]

that's good @1egoman . Can get the connect/reconnect from context.

[lukasIO]

nice!