Facebook/ASCIICrash - #2

Open

liunina wants to merge 1047 commits into

facebook/ASCIICrash

This pull request is big! We're only showing the most recent 250 commits

Commits on Oct 4, 2015

Improved messages for thread affinity and frame transform identity assertions.
Scott Goodson
committed
61bb4f0
Merge pull request #705 from facebook/ThreadAffinity
appleguy
committed
67cf6d3

Commits on Oct 5, 2015

Properly support operating with nil asyncDelegate for Table & Collection.
Scott Goodson
committed
77745c5
Optimize ASDataController._layoutNodes
Adlai-Holler
committed
4601fcc
Set node.frame entirely
Adlai-Holler
committed
33c07db
Fix index into size ranges
Adlai-Holler
committed
99b9f73
Merge pull request #708 from Adlai-Holler/FasterLayoutNodes
appleguy
committed
2f1d57e
Fix shouldRasterizeSubnodes skipping setting offset and clipping.
garrettmoon
committed
d6c107a
Address comments
garrettmoon
committed
b1d03f1

Commits on Oct 6, 2015

Commits on Oct 7, 2015

Commits on Oct 8, 2015

Merge pull request #714 from Adlai-Holler/WorkaroundPhotosDeadlock
appleguy
committed
ca5780f

Commits on Oct 10, 2015

Initial work on measuring loaded cell nodes on the main thread
Adlai-Holler
committed
e92a6ce
Don't set cell node frames during measure, set them just before returning the cell size to UITableView/UICollectionView
Adlai-Holler
committed
e716ccb
Merge branch 'DontSetCellNodeFramesDuringMeasure' into MeasureCellNodesOnMain
Adlai-Holler
committed
223e9ff
Don't set cell node frames during measurement
Adlai-Holler
committed
93cdc0f
Finish measuring on main thread when possible
Adlai-Holler
committed
06b7897
Put back the frame-setting behavior when measuring cell nodes
Adlai-Holler
committed
fdb1127
Remove public needsMeasure
Adlai-Holler
committed
d8e99e0
Revert prior change
Adlai-Holler
committed
0848aac
Remove needsMeasure
Adlai-Holler
committed
7f42b37
Finish removing needsMeasure
Adlai-Holler
committed
0eb3490
Whitespace
Adlai-Holler
committed
1e23256
Remove comment
Adlai-Holler
committed
0c36189
Remove pointless assertion
Adlai-Holler
committed
5958916

Commits on Oct 11, 2015

Commits on Oct 12, 2015

Merge branch 'master' into RelayoutCellAPI
nguyenhuy
committed
12c087d
Don't invalidateCalculatedLayout when ASTextCellNode's text is changed
nguyenhuy
committed
91f3ba1
Animate subnodes swap in Kitten example.
nguyenhuy
committed
210a89e

Commits on Oct 15, 2015

Bump podspec version to 1.9 in preparation for release.
Scott Goodson
committed
58a880e
Merge pull request #743 from facebook/Podfile
appleguy
committed
281a355
ASCellNode selected/highlighted properties
Vitaly Baev
committed
8557d65
Bump the bracket down
Vitaly Baev
committed
03542c5
ASCellNode selected/highlighted properties in ASCollectionView
Vitaly Baev
committed
1a78cd2
Merge pull request #745 from vitalybaev/ASCellNodeSelectedHighlighted
appleguy
committed
57badd9
Documentation updates

levi
authored and
Levi McCallum
committed
cefbcef
Extract flow layout methods into a separate delegate

levi
authored and
Levi McCallum
committed
2956c0c
Add launch storyboard to collection view example to fix screen size

levi
authored and
Levi McCallum
committed
4e32c07
Allow ASCollectionView to register for supplementary container

levi
authored and
Levi McCallum
committed
0d2332b
Expose collection view supplementary node data source method

levi
authored and
Levi McCallum
committed
e492770
Stub out ASCollectionDataController subclass

levi
authored and
Levi McCallum
committed
e9eadac
Define initial supplementary node creation behavior

levi
authored and
Levi McCallum
committed
ed1b737
Use objective-c++ for subclass

levi
authored and
Levi McCallum
committed
658b78d
Further implement data controller support and layout introspection

levi
authored and
Levi McCallum
committed
da7a2a5
Extract number of supplementary sections into the inspector

levi
authored and
Levi McCallum
committed
5dee3f6
Add new files to xcodeproj
Levi McCallum
committed
d765444
Fix build errors from bad merge
Levi McCallum
committed
4c6585d
Cleanup setup of default flow layout inspector
Levi McCallum
committed
a659ce7
Implement UICollectionViewFlowLayout heuristics in a default inspector
Levi McCallum
committed
73ddebe
Update copywright preamble
Levi McCallum
committed
c9f93cd
Document internal storage behaviors of ASDataController
Levi McCallum
committed
bdd786f
Document data controller node population
Levi McCallum
committed
a3dce24
Batch render supplementary views on reload data
Levi McCallum
committed
835f9e9
Clean up interfacing with internal editing/completed stores

levi
authored and
Levi McCallum
committed
afda471
Use rows mutable array for section deletion

levi
authored and
Levi McCallum
committed
f041a27
Initialize mutable editing nodes before section insertion

levi
authored and
Levi McCallum
committed
6e49e1f
Add functioning header/footer supplementary view support to example

levi
authored and
Levi McCallum
committed
e410595
Remove non-null definitions

levi
authored and
Levi McCallum
committed
aa1842e
Expose completed nodes array by kind

levi
authored and
Levi McCallum
committed
e4f274a
Localize debugging LOG definition

levi
authored and
Levi McCallum
committed
1c2046c
Fix typo

levi
authored and
Levi McCallum
committed
0086949
Fix travis build

levi
authored and
Levi McCallum
committed
ecbc29f
Assert supplementary node kind registration

levi
authored and
Levi McCallum
committed
b436a01
Optimize string concatenation

levi
authored and
Levi McCallum
committed
ba4298e
Use local method for introspecting data controller constrained sizes
Levi McCallum
committed
34f3065
Handle initial sizing delegate implementation in flow layout inspector
Levi McCallum
committed
8efca60
Asset presence of async delegate before accessing layout delegate
Levi McCallum
committed
2958c84
Batch layout as display nodes
Levi McCallum
committed
769a675
Assert supplementary node validity before data controller use
Levi McCallum
committed
5839e5b
Clean up supplementary nodes in data controller store on each reload
Levi McCallum
committed
b58649f
Constrain flow layout header/footer size to collection view bounds
Levi McCallum
committed
4321367
Relayout all nodes in backing store on `relayoutAllNodes`
Levi McCallum
committed
71966f3
Use simpler completed nodes loop
Levi McCallum
committed
ed7a733
Stub out subclass hooks for section insert/remove/update/moving
Levi McCallum
committed
f9bba31
Introduce ability to populate internal supplementary nodes at specific sections
Levi McCallum
committed
d36c8a3
Nil out pending store kinds after processing
Levi McCallum
committed
2cc5551
Handle supplementary node generation during insertion of new section
Levi McCallum
committed
e1ea2d2
Delete supplementary nodes when section is deleted
Levi McCallum
committed
d77df45
Support reloading supplementary nodes when sections reload
Levi McCallum
committed
9235ce5
Add support to move supplementary nodes with section position changes
Levi McCallum
committed
3f00924
Add tests for flow layout inspector section calculation
Levi McCallum
committed
8a77072
Test number of supplementary views in section inspector method
Levi McCallum
committed
1216d74
Add tests for constrained size method of flow layout inspector
Levi McCallum
committed
8a9720d
Clean up arrangement of data controller subclassing methods
Levi McCallum
committed
eb5c795
Clarify data controller subclass hooks
Levi McCallum
committed
4fb4119
Fix hook method naming
Levi McCallum
committed
848dc26
Clarify layout delegate assertion messages
Levi McCallum
committed
0870d50
Use ASCellNodes for supplementary nodes
Levi McCallum
committed
fddb006
Fix layout of example supplementary nodes
Levi McCallum
committed
a9023dd
Clarify default value behavior of the layoutDelegate for flow layouts
Levi McCallum
committed
ba72c73
Ignore coverage analysis files in master
Levi McCallum
committed
c8a79c5
Homogenize cell node measuring
Levi McCallum
committed
1c717c7
Remove initial data loading subclass hook
Levi McCallum
committed
952a66a
Add support for loaded node layout for supplementary views
Levi McCallum
committed
ee0cc20
Document public supplementary node methods
Levi McCallum
committed
8ac02a6
Clean up usage of internal flow layout inspector
Levi McCallum
committed
e2bbde2
Remove supplementary view assertion
Levi McCallum
committed
0446902
Document layout delegate on ASCollectionView
Levi McCallum
committed
772e9b9
Clean up layout delegate protocol API
Levi McCallum
committed
1219419
Clean up and test registration of internal supplementary node kinds
Levi McCallum
committed
9a37538
Clear collection view delegate/dataSource on test tear down
Levi McCallum
committed
31f184b
Fix variable naming in debug log
Levi McCallum
committed
55c1b8f
Ensure layout controller exposes only cell item index paths to range controller
Levi McCallum
committed
8b7ac3c

Commits on Oct 16, 2015

Ascii art for layoutables
rcancro
committed
3b983c5

Commits on Oct 19, 2015

Merge pull request #694 from levi/supplementary-views
appleguy
committed
a1dee22
Put all ascii box methods into a Debugging category.
rcancro
committed
f164b97
fixed build
rcancro
committed
5a3b021
fixed the build again (removed all generic collections)
rcancro
committed
050160e
Add snapshot tests for ASStaticLayoutSpec.
nguyenhuy
committed
938cd46

Commits on Oct 20, 2015

Call UIViewController's designated initializer in ASViewController
levi
committed
0972c56

Commits on Oct 21, 2015

Merge pull request #760 from levi/patch-4
appleguy
committed
c96813c

Commits on Oct 22, 2015

Merge pull request #752 from nguyenhuy/StaticLayousSpecTests
appleguy
committed
a88ad0a
Back internal kind collection with a set
Levi McCallum
committed
8f289d9
Used cached layout value in node remeasurement
Levi McCallum
committed
11076b1
Fix conditional block style
Levi McCallum
committed
9697eda
Make array instantiation consistent
Levi McCallum
committed
5ca1448
Assert flow layout inspector always initializes with a flow layout
Levi McCallum
committed
413307a
Cache flow layout delegate in local variable
Levi McCallum
committed
ad82c72
Use pointer comparison helpers for string equality
Levi McCallum
committed
5645724
Clarify editing transaction documentation
Levi McCallum
committed
5736e7c
Remove array fallback on editing node index paths
Levi McCallum
committed
45ff74b
Rename layoutDelegate to layoutInspector in ASCollectionView
Levi McCallum
committed
db0a032
Add assertion to flow layout inspector down casting
Levi McCallum
committed
084d608
Clean up caching of collection view delegate selectors on the inspector
Levi McCallum
committed
e8ce7fc
Remove stubbed collection view layout setter behavior
Levi McCallum
committed
e970863
Fix unit tests
Levi McCallum
committed
d9ea1b5

Commits on Oct 23, 2015

Reset inspector selector implementation cache correctly
Levi McCallum
committed
6569893
WIP synchronous reload data on collection view

levi
authored and
Levi McCallum
committed
c33d6ef
Implement basic immediate reloadData method on table and collection view
Levi McCallum
committed
722b90f
Fix method naming
Levi McCallum
committed
e0dfe8f

Commits on Oct 24, 2015

Commits on Oct 25, 2015

Commits on Oct 26, 2015

Revert "Make ASDisplayNode.name Thread Safe"
appleguy
committed
906d7c7
Merge pull request #773 from facebook/revert-768-ThreadSafeName
appleguy
committed
082683e
Merge pull request #762 from levi/supplementary-views
appleguy
committed
7d013a7
Merge pull request #766 from levi/levi/synchronous-reloaddata
appleguy
committed
8dddcaa
Merge pull request #751 from rcancro/debugBox
appleguy
committed
7a97c5c
Implement ASChangeSetDataController.
nguyenhuy
committed
5ea4b1b
Rename as_inverseCompare to asdk_inverseCompare for prefix consistency
nguyenhuy
committed
0315d62
Add documentation to ASChangeSetDataController.
nguyenhuy
committed
8745a47
Remove duplicate steps while coalescing changes in _ASHierarchyChangeSet
nguyenhuy
committed
ecc5e1a
Merge pull request #722 from nguyenhuy/RelayoutCellAPI
appleguy
committed
7e61675
Revert "Revert "Make ASDisplayNode.name Thread Safe""
nguyenhuy
committed
fd0b3aa
Add read-only names to UIView and CALayer
nguyenhuy
committed
53a3b76
Remove debugging names of ASDisplayNode and _ASDisplayLayer
nguyenhuy
committed
b77522b
Merge pull request #774 from nguyenhuy/FixFailingTestsRelatedToDisplayNodeName
appleguy
committed
6c08187
Fix comment in ASTableView
nguyenhuy
committed
1b500e4
Fix unstable tests related to relayoutAllNodes in ASTableViewTests
nguyenhuy
committed
048566a
Inject an ASDataController class to ASTableView, for testing purposes
nguyenhuy
committed
72fca53
Revert "Fix unnecessary relayout if table view width is zero initially"
nguyenhuy
committed
6644621
Merge pull request #753 from nguyenhuy/DataControllerSortedTransaction
appleguy
committed
2c8626e

Commits on Oct 27, 2015

Expose ASViewController's constrained size for subclass customization
Levi McCallum
committed
03bd1f4

Commits on Oct 28, 2015

Link to NSSpain talk
Vitaly Baev
committed
88b74a4
Fix link to NSSpain talk
Vitaly Baev
committed
681f209
release any CGColor's set while the node is in a pending state
eanagel
committed
a2bc207
Merge pull request #786 from eanagel/fix-cgcolor-leak
appleguy
committed
e46fc8e
Merge pull request #783 from vitalybaev/NSSpainTalkLink
appleguy
committed
f11b6ac
Never use setAnimationsEnabled: so we don't risk corrupting enabledness
Adlai-Holler
committed
5048566

Commits on Oct 29, 2015

Move ASDisplayNodePerformBlockOnMainThread to ASInternalHelpers
nguyenhuy
committed
cd31f88
Introduce ASCellNodeDelegate
nguyenhuy
committed
00400e1
ASTextCellNode triggers a relayout after a text change
nguyenhuy
committed
c7d18a4
Improve documentation of ASCellNode setNeedsLayout
nguyenhuy
committed
5b8f7e9
Use fast enumeration when performing collection view update blocks
Adlai-Holler
committed
cf8946c
Notify ASCellNodeDelegate even if a relayout doesn't result in a resize
nguyenhuy
committed
fb18e76

Commits on Oct 30, 2015

Commits on Oct 31, 2015

Fix retain cycle in basic, cache-less ASNetworkImageNodes
Scott Goodson
committed
3175ce2
Merge pull request #799 from facebook/RangeCleanup
appleguy
committed
40f138d
Adding ASButtonNode. Simple but flexible, add features as desired!
Scott Goodson
committed
3416450
Merge pull request #800 from facebook/ButtonNode
appleguy
committed
6e92c33
Merge pull request #796 from samhsiung/name_stacks
appleguy
committed
ae692be
Merge pull request #781 from levi/master
appleguy
committed
e11007f
Make textContainerInset configurable for ASEditableTextNode placeholder and typed textViews
samhsiung
committed
e4d2551
Add "Push Another Copy" to ASViewController demo for memory testing.
Scott Goodson
committed
2e33165
Add reload button to ASViewController demo for memory testing.
Scott Goodson
committed
59c1a64

Commits on Nov 1, 2015

Merge pull request #802 from samhsiung/add_textContainerInset
appleguy
committed
a641a6e
Add multiple view push to the ASTableViewStressTest app to evaluate memory issues
Scott Goodson
committed
fdcace6
Merge pull request #793 from nguyenhuy/ImproveCellNodeRelayout
appleguy
committed
0598935
Rename ASCellNode delegate to layoutDelegate to avoid common naming overlap
Scott Goodson
committed
e517f88
Merge pull request #806 from facebook/CellDelegateNaming
appleguy
committed
7b112a2

Commits on Nov 5, 2015

Add a ASTableNode class, similar to ASCollectionNode

Steven Ramkumar
authored and
Steven Ramkumar
committed
3018030
Merge pull request #816 from steveram/table-node
appleguy
committed
2308ae0
Merge pull request #801 from facebook/RangeTeardown
appleguy
committed
fd24314
Modify ASTableNode initializer

Steven Ramkumar
authored and
Steven Ramkumar
committed
a621e10

Commits on Nov 6, 2015

Fix ASTableViewCell's node selected/highlighted property
Vitaly Baev
committed
b1784bc
Added example of typical social app layout example
Vitaly Baev
committed
78293ad
Fixed copyright in SocialApp example
Vitaly Baev
committed
19c2e8b
fix Travis-CI build for SocialApp example
Vitaly Baev
committed
318bb03
changed deployment target and device family in SocialApp example
Vitaly Baev
committed
d143aba

Commits on Nov 7, 2015

Merge pull request #818 from steveram/table-node
appleguy
committed
ec7aa1c

Commits on Nov 8, 2015

Fix unusual cell content blanking issue when making existing cells much taller.
Scott Goodson
committed
e0f40d5
Re-add name method to fix tests (grr). Clean up positioning of responder methods in header.
Scott Goodson
committed
efa47d6
Remove a change that leaked from another diff in progress.
Scott Goodson
committed
3a4e990
Include moved UIResponder methods in UIViewBridging Category Implementation.
Scott Goodson
committed
98010c4
Merge pull request #826 from facebook/layerWorkingRangeFix
appleguy
committed
b7c5471

Commits on Nov 9, 2015

Patch for properly tearing down Working Window
Scott Goodson
committed
40237a5
Merge pull request #812 from nguyenhuy/ImproveCellNodeLayoutDelegate
appleguy
committed
7c9698a
Merge pull request #823 from vitalybaev/SocialAppExample
appleguy
committed
b295eda
Merge pull request #830 from facebook/WorkingWindowQuickFix
appleguy
committed
e8d2386
Fix crash in ASCII art creator for one-element children arrays
Scott Goodson
committed
6d8bad1