Facebook/ASCIICrash - #2
Open
liunina wants to merge 1047 commits into
Open
Conversation
Improved messages for thread affinity and frame transform identity assertions.
…Nodes Faster handling of iteration to lay out nodes in ASDataController.
…erizeSubnodes Fix shouldRasterizeSubnodes skipping setting offset and clipping.
…geNodeShortCircuit Use deep compare when setting image identifiers in ASMultiplexImageNode
…framework deadlock
Expand usage of ASObjectIsEqual to clean up / encourage fast-path compares.
Properly support operating with nil asyncDelegate for Table & Collection.
…DisablingAndEnablingShouldRasterize Adds support for disabling and re-enabling should rasterize.
Use long-form view block initializer for better Swift support
1) Set the ascender/descender of an ASTextNode when the attributeString is set. Previously ascender/descender were only being computed in `setValuesFromLayoutable` and only when the attribute string was not nil. May make sense to remove the computation from `setValuesFromLayoutable` entirely. 2) Remove ability to allow different children of a stack spec to aling to different baselines. This wasn't working before and I'm not convinced it is possible to do properly/useful enough to invest the time. 3) Have all stack spec run `ASStackBaselinePositionedLayout::compute` to compute the stack's ascender and descender. Even if the stack isn't aligning its children to a baseline, the stack itself may be a child of another stack that IS aligning to a baseline.
Fixes to baseline stack alignment
…erInset Make textContainerInset configurable for ASEditableTextNode
…emory issues No issues found. Have not been able to create a leak either with the test itself or scrolling / popping back view controlliers.
…Relayout ASCellNode delegate to automatically resize in table & collection when -setNeedsLayout called.
Rename ASCellNode delegate to layoutDelegate to avoid common naming conflict
…empty update transaction, instead of a reload
…d by the async data source
Add a ASTableNode class, similar to ASCollectionNode
Add "Push Another Copy" to ASViewController demo for memory testing.
Modify ASTableNode initializer
…der methods in header.
…eFix Fix unusual cell content blanking issue when making existing cells much taller.
…LayoutDelegate Improve cell node layout delegate
New example app -- a "social" feed similar to Facebook or Twitter
…ckFix Patch for properly tearing down Working Window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.