This repository was archived by the owner on Jul 25, 2020. It is now read-only.
Revamp Cursor::get_{text,blob} functions
#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they used to return a direct `String` or `Vec<u8>`, which may fail when it should return `NULL`. other functions do not have this issue since the automatic conversion is fully defined over INTEGER and FLOAT internal types. this commit changes them to return an optional `&str` or `&[u8]`. this correctly handles `NULL`, and moreover, reduces the redundant allocations when the buffer doesn't need to be kept. this also makes `Cursor::get_bytes` fully redundant, so it has been removed.
kud1ing
pushed a commit
that referenced
this pull request
Jul 27, 2014
Revamp `Cursor::get_{text,blob}` functions
|
Awesome, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with usual lint suppressions, these commits change
Cursor::get_{text,blob}to return anOption<&str>orOption<&[u8]>. This correctly handlesNULL(hence fixes #92), and moreover, reduces the redundant allocations when the buffer doesn't need to be kept. This also makesCursor::get_bytesfully redundant, so it has been removed.