Fix various mutability problems. #104
Conversation
- fixed a mistake that `Database` was accidentally `Send`able.
- made `Cursor::{reset, clear_bindings, step, step_row,
get_blob, get_int, get_i64, get_f64, get_text, bind_param,
bind_params}` receive `&mut self`.
- made `Database::set_busy_timeout` receive `&mut self`.
`Database::{prepare, exec}` has been left as is, since it is
perfectly safe to have multiple cursors. the associated
thread safety issue is separately handled.
closes linuxfood#98, linuxfood#99, linuxfood#100, linuxfood#101 and linuxfood#103.
Fix various mutability problems.
|
Cool, thanks. |
|
@kud1ing Can you close other relevant issues? GitHub's commit message parser is too naive to close other issues. :) |
|
@lifthrasiir: I wonder whether development should move to a more open fork. |
|
@kud1ing are you unable to grant people collaborator status? If so, we should remedy that. As for @lifthrasiir, I'll make you a collaborator as well. |
|
@linuxfood: I don't think i can. I would expect a settings menu, but i don't see that. |
|
@linuxfood Can you remove me? I'd like to retire. I had only time to merge the work of others anyway (mostly by @lifthrasiir). |
|
@kud1ing done, you are retired. |
The fix was planned after #94 but I was a bit late in the party. So, this commit fixes the following:
Databasewas accidentallySendable.Cursor::{reset, clear_bindings, step, step_row, get_blob, get_int, get_i64, get_f64, get_text, bind_param, bind_params}receive&mut self.Database::set_busy_timeoutreceive&mut self.Database::{prepare, exec}has been left as is, since it is perfectly safe to have multiple cursors (seeprepared_stmt_bind_static_text_interleavedtest for an example). The associated thread safety issue is handled by makingDatabasenon-Sendable.Closes #98, #99, #100, #101 and #103.